Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GEOT-7248] app-schema GetFeature numberMatched breaks with views/tab… #4092

Merged
merged 1 commit into from
Nov 7, 2022

Conversation

NielsCharlier
Copy link
Contributor

@NielsCharlier NielsCharlier commented Oct 31, 2022

GEOT-7248 Powered by Pull Request Badge

test: geoserver/geoserver#6319

…les without PK

https://osgeo-org.atlassian.net/browse/GEOT-7248

Checklist

For core and extension modules:

  • New unit tests have been added covering the changes.
  • Documentation has been updated (if change is visible to end users).
  • There is an issue in GeoTools Jira (except for changes not visible to end users).
  • Commit message(s) must be in the form [GEOT-XYZW] Title of the Jira ticket.
  • Bug fixes and small new features are presented as a single commit.
  • The commit targets a single objective (if multiple focuses cannot be avoided, each one is in its own commit, and has a separate ticket describing it).

Copy link
Contributor

@taba90 taba90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@aaime aaime added backport 27.x Backport to 27.x backport 28.x labels Nov 7, 2022
@aaime aaime merged commit 855b5f4 into geotools:main Nov 7, 2022
@aaime
Copy link
Member

aaime commented Nov 7, 2022

In it goes, hopefully the backport bot will create the backport PRs

@aaime
Copy link
Member

aaime commented Nov 24, 2022

According to chatter on the geoserver-users list, this change may have introduced a regression when concatenated columns are used instead of a database id column.

See the thread "[Geoserver-users] "org.postgresql.util.PSQLException" in geoserver 2.21.2 (not in 2.21.1)"

@NielsCharlier
Copy link
Contributor Author

fix for regression: #4135

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants