Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GEOT-7148] Bug in JoiningJDBCFeatureSource / FilterToSQL creates invalid SQL #4156

Merged
merged 1 commit into from
Jan 11, 2023

Conversation

taba90
Copy link
Contributor

@taba90 taba90 commented Jan 9, 2023

GEOT-7148 Powered by Pull Request Badge

Checklist

For core and extension modules:

  • New unit tests have been added covering the changes.
  • Documentation has been updated (if change is visible to end users).
  • There is an issue in GeoTools Jira (except for changes not visible to end users).
  • Commit message(s) must be in the form [GEOT-XYZW] Title of the Jira ticket.
  • Bug fixes and small new features are presented as a single commit.
  • The commit targets a single objective (if multiple focuses cannot be avoided, each one is in its own commit, and has a separate ticket describing it).

@aaime
Copy link
Member

aaime commented Jan 10, 2023

Changes look good, but the tests are failing.

@taba90
Copy link
Contributor Author

taba90 commented Jan 11, 2023

Thanks for your review @aaime, I've fixed the test. It was due the merging of this pr in the meantime (#4135) modifying the count query with an additional subquery.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants