Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IAU authority and EPSG-agnostic fixes #4284

Merged
merged 4 commits into from
May 12, 2023
Merged

Conversation

aaime
Copy link
Member

@aaime aaime commented May 8, 2023

Set of changes to make the code work beyond the EPSG authority, and a factory for planetary CRSs.
Work in progress.

Checklist

For core and extension modules:

  • New unit tests have been added covering the changes.
  • Documentation has been updated (if change is visible to end users).
  • There is an issue in GeoTools Jira (except for changes not visible to end users).
  • Commit message(s) must be in the form [GEOT-XYZW] Title of the Jira ticket.
  • Bug fixes and small new features are presented as a single commit.
  • The commit targets a single objective (if multiple focuses cannot be avoided, each one is in its own commit, and has a separate ticket describing it).

Copy link
Member

@ianturton ianturton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, no issue with it going in to supported land

@aaime aaime force-pushed the iau_authority branch 2 times, most recently from d8def87 to 6e6e19b Compare May 9, 2023 16:21
@aaime aaime marked this pull request as ready for review May 9, 2023 16:29
@aaime aaime changed the title IAU authority and EPSG-agnostic fixes (WIP) IAU authority and EPSG-agnostic fixes May 9, 2023
@aaime aaime requested a review from dromagnoli May 10, 2023 07:48
* GeoTools - The Open Source Java GIS Toolkit
* http://geotools.org
*
* (C) 2005-2008, Open Source Geospatial Foundation (OSGeo)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the YEAR right?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably not 🤣

@@ -0,0 +1,71 @@
// Test points for the Robinson projection
//
// (C) 2020, Open Source Geospatial Foundation (OSGeo)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should that be 2023?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep

@aaime aaime merged commit ff6da74 into geotools:main May 12, 2023
17 checks passed
@aaime aaime deleted the iau_authority branch May 12, 2023 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants