Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GEOT-7563] Allow to recompute an image mosaic summary Raster Attribute Table #4732

Merged
merged 1 commit into from
May 6, 2024

Conversation

aaime
Copy link
Member

@aaime aaime commented Apr 26, 2024

GEOT-7563 Powered by Pull Request Badge

Useful if new files are added or existing files are updated, that contain a different set of RAT entries (not done automatically, it can be expensive and the RAT might be uniform across files).

Checklist

For core and extension modules:

  • New unit tests have been added covering the changes.
  • Documentation has been updated (if change is visible to end users).
  • There is an issue in GeoTools Jira (except for changes not visible to end users).
  • Commit message(s) must be in the form [GEOT-XYZW] Title of the Jira ticket.
  • Bug fixes and small new features are presented as a single commit.
  • The commit targets a single objective (if multiple focuses cannot be avoided, each one is in its own commit, and has a separate ticket describing it).

Copy link
Contributor

@dromagnoli dromagnoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I think there is only a small typo on a comment describing what the test is doing.


List<Row> originalRows = rat.getRow();

// not add back the PAM file and force reload
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it "not add" or is it actually "now add" ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep

@aaime aaime added the backport 31.x Automatic backport to 31.x branch label May 6, 2024
@aaime aaime merged commit 6e79a13 into geotools:main May 6, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 31.x Automatic backport to 31.x branch
Projects
None yet
2 participants