Add a SourceName field into RasterSources #224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pomadchin
commented
Aug 5, 2019
pomadchin
force-pushed
the
feature/named-raster-source
branch
5 times, most recently
from
734e967
to
4b1e71c
Compare
pomadchin
force-pushed
the
feature/named-raster-source
branch
from
4b1e71c
to
7c2897d
Compare
echeipesh
reviewed
Aug 12, 2019
vlm/src/main/scala/geotrellis/contrib/vlm/effect/geotiff/BaseGeoTiffRasterSource.scala
Outdated
Show resolved
Hide resolved
echeipesh
reviewed
Aug 12, 2019
| @@ -39,18 +39,18 @@ import java.net.MalformedURLException | |||
| * | |||
| * @example "zip+s3://bucket/prefix/zipped-data.zip!data.tif" | |||
| */ | |||
| case class GDALDataPath(path: String) extends DataPath | |||
| case class GDALPath(value: String) extends SourcePath | |||
pomadchin
changed the title
echeipesh
reviewed
Aug 12, 2019
| @@ -21,16 +21,17 @@ import java.net.URI | |||
| /** | |||
| * Represents the path to data that is to be read. | |||
| */ | |||
| trait DataPath { | |||
| trait SourcePath extends SourceName { | |||
There was a problem hiding this comment.
Yes, this makes a lot of sense.
echeipesh
approved these changes
Aug 12, 2019
There was a problem hiding this comment.
My only comment is to get rid of Base classes and inline them to avoid cluttering up the namespace. Otherwise this is a great improvement. It gets rid of RasterSourceMetadata and solves the naming problem really efficiently. RasterSource extends RasterMetadata RasterMetadata has name: SourceName and SourcePath extends SourceName. So we can match on name and work only on RasterMetadata if required.
pomadchin
force-pushed
the
feature/named-raster-source
branch
4 times, most recently
from
fea1719
to
272f2ad
Compare
|
Merging once CI is happy! |
pomadchin
force-pushed
the
feature/named-raster-source
branch
from
272f2ad
to
062519e
Compare
pomadchin
force-pushed
the
feature/named-raster-source
branch
from
062519e
to
0ad7e92
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR allows
RasterSourcesto have a name (or identifier) different from the path, for the in memory cases or for theMosaicRasterSourcethat can't have a path to the source.Checklist
Closes #197