Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies #184

Merged
merged 5 commits into from
Dec 18, 2019
Merged

Update dependencies #184

merged 5 commits into from
Dec 18, 2019

Conversation

notthatbreezy
Copy link
Contributor

@notthatbreezy notthatbreezy commented Dec 18, 2019

Overview

This PR splits the cats ecosystem dependencies to match GeoTrellis 3.2

  • TODO: Update MAML once GeoTrellis 3.2.0 maml#112 is released -- using a snapshot until there's a release -- good enough for development for now

Checklist

  • Description of PR is in an appropriate section of the CHANGELOG and grouped with similar changes if possible

Testing Instructions

  • CI should hopefully be enough to verify everything compiles -- I reviewed evicted from the sbt shell too in order to make sure that between versions cats dependencies looked sane, but there's a lot of evictions

}
}

def monocle(module: String) = Def.setting {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will probably continue to be unused for gt-server (hopefully) I'd leave it out but meh.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh oops, good catch

Copy link
Collaborator

@echeipesh echeipesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -42,6 +74,8 @@ object Dependencies {
val http4sCirce = "org.http4s" %% "http4s-circe" % http4sVer
val http4sDsl = "org.http4s" %% "http4s-dsl" % http4sVer
val http4sXml = "org.http4s" %% "http4s-scala-xml" % http4sVer

val jaxbApi = "javax.xml.bind" % "jaxb-api" % jaxbApiVer
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added so that project compiles on Java 11

@notthatbreezy notthatbreezy merged commit a3e9c98 into develop Dec 18, 2019
@notthatbreezy notthatbreezy deleted the feature/cmb/update-gt-3.2 branch December 18, 2019 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants