GeoTrellis 3.2.0 #112
Merged
GeoTrellis 3.2.0 #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Cross version dependencies diverge - Minimize dependencies - switch to log4s
2 tasks
notthatbreezy
approved these changes
Dec 18, 2019
| } | ||
| } | ||
|
|
||
| def spark(module: String) = Def.setting { |
There was a problem hiding this comment.
Why split spark and geotrellis out if the version doesn't change based on scala version?
There was a problem hiding this comment.
Frivolous honestly, mostly trying to minimize the amount of lines that can duplicate version information but not sure this that much better.
This is one of the API breaks sadly |
pomadchin
requested changes
Dec 18, 2019
There was a problem hiding this comment.
I think we can minimize that compact package to be a single type alias.
Scala 2.11
package com.azavea.maml
package object compact {
type ParallelCompact[M[_], F[_]] = cats.Parallel[M, F]
}Scala 2.12
package object compact {
type ParallelCompact[M[_], F[_]] = cats.Parallel.Aux[M, F]
}Yes the signature would still remain a legacy one, but we won't have to support two aobsolutely different Interpreter versions with different InterpreterSpecs.
I also will prepare a PR, so feel free to decline my review if you don't like it.
pomadchin
reviewed
Dec 18, 2019
Minimize compact package
pomadchin
approved these changes
Dec 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Cross scala version dependencies diverge (ref: Switch to scala 2.12 as build default locationtech/geotrellis#3132)
Minimize dependencies for
mamlJVMTestspark-sqldependency becomesTestgeotrellis-sparkdependencygeotrellis-s3dependencyswitch from scala-logging to log4s
ParallelInterpreterforked for scala 2.11 and 2.12 based on changes incats.ParallelinterfaceChecklist