-
-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refonte : pages auteurs et section équipe #915
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
articles
Tutoriels, actualité, billet...
contributeurices
Contenus liés à la contribution et contributeur/ices : biographies, à propos, etc.
labels
May 1, 2023
This comment has been minimized.
This comment has been minimized.
2 similar comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Guts
force-pushed
the
feature/improve-authors-integration
branch
from
April 26, 2024 18:18
f2e0558
to
2a8c9e2
Compare
github-actions
bot
added
the
enhancement
Ajout ou amélioration d'une fonctionnalité
label
Apr 26, 2024
This comment has been minimized.
This comment has been minimized.
github-actions
bot
added
the
outillage
Linter, git hooks, CI, CD, build, compilation, devops, intégration et déploiement continus, etc.
label
Apr 27, 2024
This comment has been minimized.
This comment has been minimized.
github-actions
bot
added
the
thème
Personnalisation du thème du site (CSS, JS, partials...)
label
Apr 28, 2024
This comment has been minimized.
This comment has been minimized.
9 tasks
github-actions
bot
added
rdp
Revues de presse
mkdocs
Tout ce qui est lié au générateur de site : configuration, hooks, scripts...
labels
May 2, 2024
This comment has been minimized.
This comment has been minimized.
2 similar comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
github-actions
bot
added
the
contenus communs
Contenus génériques et communs au site : page d'accueil, glossaire, snippets, licences...
label
May 2, 2024
This comment has been minimized.
This comment has been minimized.
Guts
force-pushed
the
feature/improve-authors-integration
branch
from
May 3, 2024 07:02
612abaa
to
46e2de8
Compare
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
…uteur/ices à partir d'un marqueur en commentaire
Guts
force-pushed
the
feature/improve-authors-integration
branch
from
May 3, 2024 07:39
46e2de8
to
243898b
Compare
This comment has been minimized.
This comment has been minimized.
Guts
changed the title
Amélioration des pages auteurs
Refonte : pages auteurs et section équipe
May 3, 2024
This comment has been minimized.
This comment has been minimized.
gounux
reviewed
May 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
C'est cool ça @Guts
Co-authored-by: Guilhem Allaman <40383801+gounux@users.noreply.github.com> Signed-off-by: Julien <dev@ingeoveritas.com>
Co-authored-by: Guilhem Allaman <40383801+gounux@users.noreply.github.com> Signed-off-by: Julien <dev@ingeoveritas.com>
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
gounux
reviewed
May 3, 2024
Co-authored-by: Guilhem Allaman <40383801+gounux@users.noreply.github.com> Signed-off-by: Julien <dev@ingeoveritas.com>
This comment has been minimized.
This comment has been minimized.
gounux
reviewed
May 4, 2024
Co-authored-by: Guilhem Allaman <40383801+gounux@users.noreply.github.com> Signed-off-by: Julien <dev@ingeoveritas.com>
👏 Le markdown ajouté ou modifié est impeccable ! Merci 🥇 |
🎉 Le site de prévisualisation pour cette PR a été généré et est disponible sous ce lien. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
articles
Tutoriels, actualité, billet...
contenus communs
Contenus génériques et communs au site : page d'accueil, glossaire, snippets, licences...
contributeurices
Contenus liés à la contribution et contributeur/ices : biographies, à propos, etc.
enhancement
Ajout ou amélioration d'une fonctionnalité
mkdocs
Tout ce qui est lié au générateur de site : configuration, hooks, scripts...
outillage
Linter, git hooks, CI, CD, build, compilation, devops, intégration et déploiement continus, etc.
rdp
Revues de presse
thème
Personnalisation du thème du site (CSS, JS, partials...)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objectifs
Résoudre quelques problèmes et répondre à certains besoins liés aux pages/blocs auteur/ice :
h1
par page)Changements effectués
Le code d'intégration du bloc auteur
Désormais l'intégration tient en un commentaire :
<!-- geotribu:authors-block -->
Note
Il faut que ce commentaire soit présent dans la page. Je ferai une évolution pour vérifier et l'ajouter à la volée.
Un hook vient automatiquement intégrer le bloc auteur en gérant :
Avant
Après
La page auteur/ice
Une page auteur/ice est désormais une page à part entière avec les mêmes options que les autres dans l'en-tête (image, icon, description, sous-titre, etc.) plus des options spécifiques pour les comptes sur les réseaux sociaux :
Pour l'instant ces informations ne sont pas utilisées mais le seront dans #1086 entre autres.
Balises de définition du bloc de signature
L'un des éléments bloquants jusqu'à présent était que l'intégration du bloc auteur était la page entière, ce qui empêchait d'y mettre plus que quelques lignes.
Désormais il faut indiquer où commence et où finit la partie de la page qui est destinée à être intégrée comme signature.
Exemple :
Limitations
Caution
Aucun niveau de titre > 3 ne doit faire partie du bloc de signature.
Section "À propos" scindée
Avant :
Après :
À suivre
Dans de prochaines PRs :