Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide generic Index for all columns #141

Closed
mbastian opened this issue Nov 2, 2021 · 0 comments
Closed

Provide generic Index for all columns #141

mbastian opened this issue Nov 2, 2021 · 0 comments
Assignees

Comments

@mbastian
Copy link
Member

mbastian commented Nov 2, 2021

In Gephi's Appearance module we have a lot of conditional branches on whether the column is indexed or not. We have logic to get values and counts for dynamic, non-indexed columns. It would be simpler if GraphStore could provide the functionalities of the Index even for non-index columns. In other words, I think we should always provide an Index for each column. The underlying Index implementation could fallback to element iteration.

@mbastian mbastian self-assigned this Dec 27, 2021
@mbastian mbastian added this to the 0.6.1 milestone Jan 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant