-
-
Notifications
You must be signed in to change notification settings - Fork 138
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #268 from nurfed1/master
Bugfix: Add quotes around network path
- Loading branch information
Showing
1 changed file
with
2 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b4d8502
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This commit is majorly slowing down my system when I run gsudo in terminal from a network share.
It also hangs on one connection which I'm sure because that server is asking for credentials. When I notice this I hit enter and it then continues on.
SUGGESTION: add a check condition for https://learn.microsoft.com/en-US/troubleshoot/windows-client/networking/mapped-drives-not-available-from-elevated-command and only run NET USE if that is not enabled.
b4d8502
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
EXAMPLE: (Not 100% precise as I had to hit enter twice and type in exit to get the time)
![image](https://private-user-images.githubusercontent.com/14026600/243799017-f5a72b80-3914-4f59-9cf9-503eb9fe559c.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjU3NjEyMzQsIm5iZiI6MTcyNTc2MDkzNCwicGF0aCI6Ii8xNDAyNjYwMC8yNDM3OTkwMTctZjVhNzJiODAtMzkxNC00ZjU5LTljZjktNTAzZWI5ZmU1NTljLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA5MDglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwOTA4VDAyMDIxNFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTFjNzhkZDNlYjcxNDg3YTE2NTNhMDdkNjY2MGQ3MmNlMzY1NDA1ZTU0ZDc1OTdkNjkyMGViZmM2MWVlOThiYzUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.3dEiAcHzvw8sSD1jSAL1tSAI0QZ6ID0Ag0_UL2E3WU4)
So two minutes, minus maybe 30+ seconds or so of my inaction.
SECOND RUN where I hit enter at each mapping to avoid delays:
![image](https://private-user-images.githubusercontent.com/14026600/243799508-86be296b-1d90-4441-801e-d826c0fc1cbd.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjU3NjEyMzQsIm5iZiI6MTcyNTc2MDkzNCwicGF0aCI6Ii8xNDAyNjYwMC8yNDM3OTk1MDgtODZiZTI5NmItMWQ5MC00NDQxLTgwMWUtZDgyNmMwZmMxY2JkLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA5MDglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwOTA4VDAyMDIxNFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWViMGIwM2I3NmU0NzhmMzY1YTJkMTcxYmQ5ZWU0ODdkNjNmY2E0NTgwYzBkMmUxMjM4ZWMwZjU4NzhmOTQyNzEmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.Wyj7vCc1K_gx3y91p_zuSz5Wm8sEJNcnmXVRLCRTfWg)