clang-tidy stuff #1237
Merged
clang-tidy stuff #1237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neheb
force-pushed
the
k
branch
3 times, most recently
from
e94e31b
to
edd6635
Compare
KarlStraussberger
requested changes
Feb 18, 2021
neheb
force-pushed
the
k
branch
3 times, most recently
from
f3e66f6
to
671cd97
Compare
|
It's still breaking. Most of the refs in |
|
Did the changes that @KarlStraussberger ask for make it in? Doesnt look like more commits have been added? |
|
Updated. |
KarlStraussberger
requested changes
Feb 24, 2021
src/metadata/metacontent_handler.h
Outdated
| void fillMetadata(std::shared_ptr<CdsObject> obj) override; | ||
| std::unique_ptr<IOHandler> serveContent(std::shared_ptr<CdsObject> obj, int resNum) override; | ||
| void fillMetadata(std::shared_ptr<CdsObject> item) override; | ||
| std::unique_ptr<IOHandler> serveContent(std::shared_ptr<CdsObject> item, int resNum) override; | ||
|
|
There was a problem hiding this comment.
It's CdsObject so the paramter should be named obj. Maybe it's not done in MetadataHnadler
There was a problem hiding this comment.
Please rename the arguments in implentation. Declaration is as it should be.
There are a lot more breaking changes. I'd prefer to leave those references as they were. |
neheb
force-pushed
the
k
branch
2 times, most recently
from
d11bd4b
to
6b56a36
Compare
|
I removed the reference changes. |
|
I also commented on the renamed arguments. The parameters in the headers are fine. The code should be renamed. |
Found with google-explicit-constructor Signed-off-by: Rosen Penev <rosenp@gmail.com>
Found with google-build-using-namespace Signed-off-by: Rosen Penev <rosenp@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
last commit was done manually. I pay have messed something up.