Change C file handling to fs:directory_entry #1312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove C file handling
KarlStraussberger
force-pushed
the
fs-directory-entry
branch
from
d2dd6d2
to
0605fdd
Compare
KarlStraussberger
force-pushed
the
fs-directory-entry
branch
from
0605fdd
to
ae05707
Compare
KarlStraussberger
changed the title
whyman
approved these changes
Mar 15, 2021
| struct dirent* dent; | ||
| while ((dent = readdir(dir)) != nullptr) { | ||
| char* name = dent->d_name; | ||
| for (const auto& dirEnt : fs::directory_iterator(location, fs::directory_options::skip_permission_denied, ec)) { |
There was a problem hiding this comment.
dirEnt is redefined here, I wonder if we can give it a more clear name? or change the other one?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.