Fix crash in filetoMimeType and remove ancient Solaris hack #1318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix null dereference in Mime::fileToMimeType
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
13 years ago in the original mediatomb, a hack was done to allow printf() of a NULL pointer to print "NULL" rather than crash, on Solaris
That was done by mapping *0=0 behind the scenes, which makes a null dereference no longer an immediate crash, which it otherwise is on Solaroid machines, and quite deliberately
No, just, no - a nullptr dereference is a bug
Removed
And then I rather quickly found a crash which was hiding behind a totally messed up stack otherwise
Mime::fileToMimeType was blindly dereferencing a nullptr to see if it pointed to an empty string