fs::path conversions #1339
Merged
fs::path conversions #1339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whyman
reviewed
Mar 24, 2021
KarlStraussberger
requested changes
Mar 24, 2021
there are several places in the code that implicitly convert an fs::path to an std::string. This breaks on platforms like Windows where the paths are wstrings. Remove some of these implicit conversions and make others explicit. Signed-off-by: Rosen Penev <rosenp@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
there are several places in the code that implicitly convert an
fs::path to an std::string. This breaks on platforms like Windows
where the paths are wstrings. Remove some of these implicit
conversions and make others explicit.
Signed-off-by: Rosen Penev rosenp@gmail.com