Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

random fixes #1357

Merged
merged 3 commits into from
Apr 6, 2021
Merged

random fixes #1357

merged 3 commits into from
Apr 6, 2021

Conversation

neheb
Copy link
Contributor

@neheb neheb commented Apr 3, 2021

No description provided.

@whyman
Copy link
Member

whyman commented Apr 3, 2021

You can rebase on master to fix the CI

@neheb neheb force-pushed the cl branch 2 times, most recently from f2d4616 to 061f1da Compare April 5, 2021 00:55
src/file_request_handler.cc Outdated Show resolved Hide resolved
src/file_request_handler.cc Outdated Show resolved Hide resolved
src/file_request_handler.cc Outdated Show resolved Hide resolved
Found with bugprone-branch-clone

Signed-off-by: Rosen Penev <rosenp@gmail.com>
Found with bugprone-narrowing-conversions

Signed-off-by: Rosen Penev <rosenp@gmail.com>
@neheb neheb force-pushed the cl branch 2 times, most recently from 35b665c to fa0e437 Compare April 6, 2021 00:34
Reduces compiled size:

2516324
1569224

2511988
1565128

Signed-off-by: Rosen Penev <rosenp@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants