Fix transcoded media ends before file is complete

[dyseg]

Also removed ATTR_TRANSCODING_PROFILES_PROFLE_USECHUNKEDENC option, which wasn't used.

[KarlStraussberger]

Are you sure, we do not need this kind of cleanup. I am afraid of memory leaks or dead threads.

[dyseg]

I looked into it again. The transcoding process is always cleaned up eventually by calling ProcessIOHandler::close() either by the BufferedIOHandler class which holds the instance of ProcessIOHandler, or from the destructor. But with this modification it is only cleaned up when we transferred all content to the client, until then the transcoding process is in zombie state. For how much time it depends on the buffer settings, but likely for 10-20-30 seconds. I'll push changes to prevent this shortly.

[KarlStraussberger]

Otherwise looks good to me.

[KarlStraussberger]

Fixes #917

[neheb]

This breaks npupnp support. UPNP_USING_CHUNKED is not implemented.

[dyseg]

This breaks npupnp support. UPNP_USING_CHUNKED is not implemented.

You're right. Should we restore the original value in case of npupnp until a solution is found? I just checked and with -1 and npupnp the transcoding is again ends before it should be. But at least this part of the code would compile.

#if defined(USING_NPUPNP)
        UpnpFileInfo_set_FileLength(info, -1);
#else
        UpnpFileInfo_set_FileLength(info, UPNP_USING_CHUNKED);
#endif

[KarlStraussberger]

This breaks npupnp support. UPNP_USING_CHUNKED is not implemented.

You're right. Should we restore the original value in case of npupnp until a solution is found? I just checked and with -1 and npupnp the transcoding is again ends before it should be. But at least this part of the code would compile.

#if defined(USING_NPUPNP)
        UpnpFileInfo_set_FileLength(info, -1);
#else
        UpnpFileInfo_set_FileLength(info, UPNP_USING_CHUNKED);
#endif

Can you provide a PR, please?

[neheb]

@dyseg I posted an issue at npupnp upstream. If implemented, no. Although the minimum version should be updated.

[neheb]

Maybe just adding ifndef UPNP_USING_CHUNKED is enough.