Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement UPnP SortCriteria #1403

Merged
merged 4 commits into from
Apr 14, 2021
Merged

Conversation

KarlStraussberger
Copy link
Member

Reworked select statements in sql_database.cc on the way

@KarlStraussberger KarlStraussberger changed the title Implement UPnP SortCriteria for browse request Implement UPnP SortCriteria Apr 14, 2021
@whyman
Copy link
Member

whyman commented Apr 14, 2021

Ive been wanted to change that enum for so long!

I dont suppose you feel like adding some more DB/SQL tests while it is fresh in your memory?

@KarlStraussberger
Copy link
Member Author

Ive been wanted to change that enum for so long!

I simply could not bear the DEFINE anymore 😄

I dont suppose you feel like adding some more DB/SQL tests while it is fresh in your memory?

I was already thinking about how to write simple tests, but that would require further work to access all the definitions which is not on my schedule a the moment. Maybe that comes up with the UPnP-Filter thing because it requires more flexible metadata browse results (Kodi sends nice Filter requests).

@whyman whyman merged commit 96df785 into gerbera:master Apr 14, 2021
@KarlStraussberger KarlStraussberger deleted the upnp-sort branch April 14, 2021 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants