Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgrade libspdlog dependency to 1.8.1 #1944

Merged
merged 1 commit into from Sep 15, 2021

Conversation

matthiasstraka
Copy link
Contributor

There is only one line of code that prevents SpdLog 1.8.1 to be used. Downgrading to 1.8.1 makes it easier to build on Ubuntu Hirsute with standard packages.
The #if SPDLOG_VERSION >= 10802 is up for discussion, I just left it in there so we can later easily identify old code when Ubuntu updates spdlog to 1.8.2 or newer.

@KarlStraussberger
Copy link
Member

Thank you for working this out. We still build using our install-scripts, so I'm fine with it

@KarlStraussberger KarlStraussberger merged commit 98c523d into gerbera:master Sep 15, 2021
@matthiasstraka
Copy link
Contributor Author

Thanks. Hopefully, we can one day have a self-sufficient build on Ubuntu and install a current gerbera using apt install gerbera to increase the number of users.

@neheb
Copy link
Contributor

neheb commented Sep 15, 2021

Gerbera right now compiles with much lower versions.

In any case, the meson PR solves this differently.

@KarlStraussberger
Copy link
Member

We'll have to wait another year or two for that. During the last 18 months gerbera pushed forward a lot faster than any distro will be able to follow.

@matthiasstraka matthiasstraka deleted the downgrade_spdlog branch September 16, 2021 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants