Optimize SQL Statements / result gathering #2007
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neheb
reviewed
Oct 7, 2021
| /// \brief Set entire metadata dictionary by moving | ||
| void setMetaData(std::vector<std::pair<std::string, std::string>>&& metaData) | ||
| { | ||
| this->metaData = std::move(metaData); |
There was a problem hiding this comment.
I don't know if it's a good idea to have setters moving stuff.
There was a problem hiding this comment.
Why not? Isn't this a very common pattern and one of the main reasons for move?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
SQLDatabase::getChildCounts, we can require the database to return orderedparent_ids and speedup map insertion (theORDER BYis only there for readability as the result should be ordered by default in both SQLite and MySQL because is uses an index onparent_id).Also, some more libfmt-identifier() conversions.