Reduce Header Nesting #2751
Merged
Reduce Header Nesting #2751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KarlStraussberger
force-pushed
the
header-nesting
branch
from
cc21252
to
2baaea4
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+55
to
+63
| /* | ||
| void CdsContainer::validate() const | ||
| { | ||
| CdsObject::validate(); | ||
| /// \todo well.. we have to know if a container is a real directory or just a virtual container in the database | ||
| if (!fs::is_directory(this->location, true)) | ||
| throw_std_runtime_error("validation failed"); | ||
| } | ||
| */ |
Check notice
Code scanning / CodeQL
Commented-out code
| void CdsItem::validate() const | ||
| { | ||
| CdsObject::validate(); | ||
| // log_info("mime: [{}] loc [{}]", this->mimeType.c_str(), this->location.c_str()); |
Check notice
Code scanning / CodeQL
Commented-out code
| if (!obj->isItem()) | ||
| return; | ||
| auto item = std::static_pointer_cast<CdsItem>(obj); | ||
| // item->setDescription(description); |
Check notice
Code scanning / CodeQL
Commented-out code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split large headers and source files