Add artist chronology container #2848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gobater
changed the title
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
@KarlStraussberger , before I fix the tests, I would like to have your opinion on this... |
It's absolutely fine. Go ahead. |
gobater
changed the title
gobater
force-pushed
the
chronology
branch
2 times, most recently
from
63f27b6
to
8a7c2a6
Compare
|
@KarlStraussberger , can you give me a hand fixing the broken test? It's passing in my machine :-( and I would expect it to pass in the CI since mock-config-minimal.xml seems correct to me. |
|
The one missing is in |
|
There are several combinations of #defines that we test, hence all the xml-files |
|
Sorry it's |
|
Oh! My bad! I didn't realize that my work was not in synch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an artist chronology container (similar to album container, but sorted by date instead of name)