clang-tidy fixes #2978
Merged
clang-tidy fixes #2978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
neheb
force-pushed
the
cll
branch
2 times, most recently
from
d22fe9b
to
e2961ea
Compare
KarlStraussberger
requested changes
Jan 22, 2024
Found with modernize-type-traits Signed-off-by: Rosen Penev <rosenp@gmail.com>
Found with clang-analyzer-cplusplus.Move Also changed these to references instead of values Signed-off-by: Rosen Penev <rosenp@gmail.com>
Found with performance-for-range-copy Signed-off-by: Rosen Penev <rosenp@gmail.com>
Found with performance-avoid-endl Signed-off-by: Rosen Penev <rosenp@gmail.com>
Found with readability-simplify-boolean-expr Signed-off-by: Rosen Penev <rosenp@gmail.com>
Found with readability-container-size-empty Signed-off-by: Rosen Penev <rosenp@gmail.com>
Found with cppcoreguidelines-avoid-const-or-ref-data-members Signed-off-by: Rosen Penev <rosenp@gmail.com>
Found with cppcoreguidelines-pro-type-static-cast-downcast Signed-off-by: Rosen Penev <rosenp@gmail.com>
Found with llvm-else-after-return Signed-off-by: Rosen Penev <rosenp@gmail.com>
Found with modernize-type-traits Signed-off-by: Rosen Penev <rosenp@gmail.com>
Found with modernize-use-using Signed-off-by: Rosen Penev <rosenp@gmail.com>
Found with modernize-pass-by-value Signed-off-by: Rosen Penev <rosenp@gmail.com>
Found with performance-unnecessary-value-param Signed-off-by: Rosen Penev <rosenp@gmail.com>
Found with performance* Signed-off-by: Rosen Penev <rosenp@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.