Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker image usability #2996

Merged
merged 5 commits into from Feb 9, 2024

Conversation

mzuther
Copy link
Contributor

@mzuther mzuther commented Feb 6, 2024

Hi!

This is my first contribution to Gerbera. It aims at making the Gerbera Docker image more customizable for users who do not want to write their own Dockerfiles:

  • simplify adding custom JavaScript code
    • add directory /mnt/customization/js for custom JavaScript files
    • add this directory to config.xml on creation
  • clarify that content directory will be "mounted" to a directory on the host
    • add directory /content to /mnt/content and use that by default
    • link /content to /mnt/content for backward compatibility
  • ease customization of config.xml when it is created
    • add directory /mnt/customization/shell
    • call script /mnt/customization/shell/gerbera_config.sh (if existing)
      whenever config.xml is created
  • update documentation

I think that these modifications do not add much overhead, while making the life of "normal" users of the Docker image much easier. But I am willing to discuss any of the modifications, of course.

Thanks for reviving MediaTomb, an application I always liked, and which has been improved so much by you!

Best,
Martin

- unless overwritten, `/mnt/content` is just a symlink to `/content`
- the new directory is located at `/mnt/customization/js

- this directory is automatically added to `custom.xml` on creation
- add directory `/mnt/customization/shell`

- run `/mnt/customization/shell/gerbera_config.sh` whenever
  Gerbera creates `config.xml`
Copy link
Member

@KarlStraussberger KarlStraussberger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also update Dockerfile.debug for consistency.

Thank you for contributing!

Dockerfile Show resolved Hide resolved
@KarlStraussberger KarlStraussberger merged commit d1d3c97 into gerbera:master Feb 9, 2024
19 checks passed
@mzuther mzuther deleted the docker_image_usability branch February 9, 2024 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants