Don't override interface flags for spdlog. #804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Finding fmt explicitly is not needed since it's handled by spdlog's CMake files. Fixes: gerbera#691.
|
Attempt number 2 :) I looked at spdlog history and it seems they switched to fmt 6.0 in version 1.4. I also checked on my ubuntu 19.10 with libspdlog-dev=1:1.3.1-1 and libfmt-dev=5.2.1+ds-2, seems to build (although I've got my warning about However I can remove it if you don't want to have it. |
|
Docker build failed with |
If spdlog found via find_library then CMakeFiles are not read and SPDLOG_FMT_EXTERNAL variable is undefined.
|
I think I have an idea why this is happening. This could then be the reason for adding define of |
|
LGTM! Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finding fmt explicitly is not needed since it's handled by spdlog's
CMake files.
Fixes: #691.