avoid exceptions #828
Merged
avoid exceptions #828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
replaced more std::stoi by stoi_string to avoid exception when reading unformatted data
|
I think I prefer this to just blow up. The DB schema should enforce good data and if not then we probably can't handle that case anyway... |
|
I encountered a crash with malformed track numbers. So we should at least handle track number safely and implement try-catch-blocks on the outer levels (search, browse, import) for proper logging of errors. |
|
Perhaps we should include the |
Only check format of tracknumber
whorfin
pushed a commit
to whorfin/gerbera
that referenced
this pull request
May 26, 2020
* avoid exceptions replaced more std::stoi by stoi_string to avoid exception when reading unformatted data * Update sql_storage.cc Only check format of tracknumber
whorfin
pushed a commit
to whorfin/gerbera
that referenced
this pull request
May 26, 2020
* avoid exceptions replaced more std::stoi by stoi_string to avoid exception when reading unformatted data * Update sql_storage.cc Only check format of tracknumber
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
replaced more std::stoi by stoi_string to avoid exception when reading unformatted data. May be a bit slower but is much safer