Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

empty() might not be perfect here, if a key is not a reference ..., i.e. a DECIMAL 0 #23

Closed
hwde opened this issue Mar 16, 2018 · 1 comment
Closed

empty() might not be perfect here, if a key is not a reference ..., i.e. a DECIMAL 0 #23

hwde opened this issue Mar 16, 2018 · 1 comment
Labels
bug on dev Already fixed on dev branch

Comments

@hwde
Copy link
Contributor

hwde commented Mar 16, 2018

gyro-php/gyro/core/model/base/dataobjectbase.cls.php

Line 216 in ee9352e

if (empty($this->$key_column)) {

@gerdriesselmann
Copy link
Owner

Seems legit.

gerdriesselmann pushed a commit that referenced this issue Jan 5, 2020
#23 Use isset() for checking if a field value is already set, not emp…
c55c993 
…ty(). Also move this to a single function instead of harcoding the check all over.
@gerdriesselmann gerdriesselmann added on dev Already fixed on dev branch bug labels Jan 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug on dev Already fixed on dev branch
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gerdriesselmann @hwde