Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow setting release notes #3

Merged
merged 3 commits into from Aug 24, 2020
Merged

Conversation

glacials
Copy link
Contributor

Thanks for this great script! It's made my life a lot easier. I wanted to be able to set release notes from it, so I built this argument.

python main.py key.json package.name release.aab --release-notes en-US "Performance improvements"

It also supports multiple languages:

python main.py key.json package.name release.aab --release-notes en-US "Performance improvements" --release-notes zh-CN "性能提升"

If not provided, everything will work as it does currently.

My use case for building this is to automatically generate release notes from recent Git commits :) Thanks again! Let me know if there's anything you want me to change.

Thanks for this great script! It's made my life a lot easier. I wanted to be
able to set release notes from it, so I built this argument.

```sh
python main.py key.json package.name release.aab --release-notes en-US "Performance improvements"
```

It also supports multiple languages:
```sh
python main.py key.json package.name release.aab --release-notes en-US "Performance improvements" --release-notes zh-CN "性能提升"
```

If not provided, everything will work as it does currently.

My use case for building this is to automatically generate release notes from
recent Git commits :)
@german1608
Copy link
Owner

@glacials thanks for your contribution! I'm really happy that this is script is being helpful and I'm looking forward to review this PR

Tomorrow I can give it a proper look

main.py Outdated Show resolved Hide resolved
Co-authored-by: German Robayo <germanrobayo33@gmail.com>
Copy link
Owner

@german1608 german1608 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a minor comment, sorry for not pointing that out at the beginning!

main.py Outdated Show resolved Hide resolved
Co-authored-by: German Robayo <germanrobayo33@gmail.com>
Copy link
Owner

@german1608 german1608 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Thanks for your contribution @glacials 😄

@german1608 german1608 merged commit a13e11a into german1608:master Aug 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants