Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add issue template for holiday additions/corrections #59

Closed
gerrymanoim opened this issue Jul 20, 2021 · 2 comments · Fixed by #99
Closed

Add issue template for holiday additions/corrections #59

gerrymanoim opened this issue Jul 20, 2021 · 2 comments · Fixed by #99

Comments

@gerrymanoim
Copy link
Owner

Need some text about updating tests, putting the source of the change in the PR, etc.
@pbabics
Copy link

pbabics commented Jul 20, 2021 •
edited by maread99
Loading

For adding new calendar I would suggest using simple checklist:

  • Added new exchange to readme
  • Added calendar class (python module like exchange_calendars/exchange_calendar_<Exchange MIC>.py)
    • Class should contain reference to trading calendar on exchange website
  • Referenced new calendar in exchange_calendars/calendar_utils.py
  • Added tests (e.g tests/test_xbse_calendar.py)
    • You can generate tests input using python etc/make_exchange_calendar_test_csv.py <Exchange MIC>

@maread99 maread99 mentioned this issue Jul 23, 2021
Open
10 tasks
@maread99
Copy link
Collaborator

A workflow to make changes to an existing calendar should include the points here.

@gerrymanoim gerrymanoim mentioned this issue Oct 15, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

DEV: Add a PR template gerrymanoim/exchange_calendars
3 participants
@gerrymanoim @pbabics @maread99