Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XLON: add Queen Elizabeth II funeral day 2022-09-12 #230

Conversation

monkeyusage
Copy link

Workflow to modify an existing Exchange Calendar

  • Modify calendar class as required.
  • Modify the test resources file (e.g tests/resources/{Exchange MIC}.csv), either manually or by executing python etc/make_exchange_calendar_test_csv.py {Exchange MIC}.
  • Check if any of the fixtures in tests/test_{Exchange MIC}_calendar.py need updating to reflect your changes.
  • Add references to any new/modified holidays in exchange_calendars/exchange_calendar_{Exchange MIC}.py.

@monkeyusage
Copy link
Author

This PR is related to issue #229

@maread99
Copy link
Collaborator

maread99 commented Sep 13, 2022

Fixes #229

Thanks for the PR @monkeyusage!

@maread99 maread99 added the calendar update Calendar needs updating label Sep 13, 2022
@maread99 maread99 merged commit 37f6fec into gerrymanoim:master Sep 13, 2022
@jenskeiner
Copy link

Nice one, couldn’t do myself due to lack of time.

@mixilchenko
Copy link

Hi, @gerrymanoim
Could you please build a new release with this change?

@maread99
Copy link
Collaborator

Done, release 4.2.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
calendar update Calendar needs updating
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants