Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Add 2024-02-09 Chinese New Year to XSHG #365

Merged
merged 1 commit into from
Feb 12, 2024

Conversation

herebebeasties
Copy link

XSHG is missing last Friday from its list, which was the beginning of the Chinese New Year celebrations - see http://english.sse.com.cn/start/trading/schedule/ for the canonical list of holidays for 2024. I've also checked no others are missing. 馃憤馃徎

Workflow to modify an existing Exchange Calendar

  • Modify calendar class as required.
  • Modify the test resources file (e.g tests/resources/{Exchange MIC}.csv), either manually or by executing python etc/make_exchange_calendar_test_csv.py {Exchange MIC}.
  • Check if any of the fixtures in tests/test_{Exchange MIC}_calendar.py need updating to reflect your changes.
  • Add references to any new/modified holidays in exchange_calendars/exchange_calendar_{Exchange MIC}.py.

@maread99 maread99 merged commit 33403bb into gerrymanoim:master Feb 12, 2024
8 checks passed
@maread99
Copy link
Collaborator

Thanks @herebebeasties!

@herebebeasties herebebeasties deleted the xshg-2024-02-09 branch February 12, 2024 23:52
@herebebeasties herebebeasties changed the title Add 2024-02-09 Chinese New Year to XSHG ENH: Add 2024-02-09 Chinese New Year to XSHG Feb 13, 2024
@github-actions github-actions bot added the enhancement New feature or request label Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants