Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to groovy 4 #579

Merged
merged 1 commit into from
Oct 12, 2023
Merged

update to groovy 4 #579

merged 1 commit into from
Oct 12, 2023

Conversation

sgrell
Copy link
Contributor

@sgrell sgrell commented Oct 11, 2023

Updated everything to Groovy 4, fixes #578

The test showed showed some strange error messages:

groovy.lang.MissingPropertyException: No such property: automated for class: de.gesellix.docker.remote.api.ImageSearchResponseItem

groovy.lang.MissingPropertyException: No such property: official for class: de.gesellix.docker.remote.api.ImageSearchResponseItem

I fixed it by using the "real" getter-methods.

I don't know if this is a real issue with groovy 4 and might have to be addressed at some other places as well.

@gesellix
Copy link
Owner

I'm going to make some changes in the api-model library, so that the MissingPropertyException won't require the workaround anymore. Seems like Groovy 4 changed some semantics for property access on fields not following the JavaBeans convention (isOfficial should have been official).

@gesellix gesellix force-pushed the update-groovy4 branch 2 times, most recently from baf4807 to 3b8a6e5 Compare October 12, 2023 21:32
@gesellix gesellix merged commit 99e8db5 into gesellix:main Oct 12, 2023
@gesellix
Copy link
Owner

Thanks! I removed the commit with the workaround for the MissingPropertyException.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update to groovy4
2 participants