-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added dynamic argument checking for 'readODS:read_ods()' #225
Conversation
gesistsa#223. Also more detailed tests.
Codecov Report
@@ Coverage Diff @@
## master #225 +/- ##
==========================================
+ Coverage 82.43% 82.78% +0.35%
==========================================
Files 18 18
Lines 871 889 +18
==========================================
+ Hits 718 736 +18
Misses 153 153
Continue to review full report at Codecov.
|
I'm watching a series of related issues and PRs here re: The tidyverse/r-lib packages are using the ellipsis package for similar functionality, in case that holds any interest. Yes, it would be a dependency. But it would also eliminate the need to grow your own solution here. YMMV 🤷♀️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good - just a couple of nits.
…99 in import_methods.R
One of the build environments failed during setup, prior to deployment of package: Travis...
Appveyor maybe this part ...
|
Added dynamic argument checking for 'readODS:read_ods()' as proposed in #223. Also more detailed tests.
Please ensure the following before submitting a PR:
Note: was I supposed to increment NEWS.md to rio 0.5.21 or add my changes to the 0.5.20 entry?
/R
not/man
and rundevtools::document()
to update documentation/tests
for any new functionality or bug fixR CMD check
runs without error before submitting the PROnly pre-existing error, not caused by this PR