Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'.import.rio_rdata()' and 'import.rio_rds()' no longer passing '...' … #229

Merged
merged 1 commit into from
Oct 2, 2019

Conversation

bokov
Copy link
Contributor

@bokov bokov commented Sep 23, 2019

…to 'load()' nor to 'readRDS()' because those underlying functions cannot accept '...' arguments. Instead, the length of '...' is checked and if > 0 a warning is issued. With corresponding tests. As proposed in #223

Please ensure the following before submitting a PR:

No failures attributable to this PR.

…to 'load()' nor to 'readRDS()' because those underlying functions cannot accept '...' arguments. Instead, the length of '...' is checked and if > 0 a warning is issued. With corresponding tests. As proposed in gesistsa#223
@bokov
Copy link
Contributor Author

bokov commented Sep 23, 2019

SInce the rds format has the same issue as rdata and they're thematically related I included that too, and did tests for it as well.

@codecov-io
Copy link

codecov-io commented Sep 23, 2019

Codecov Report

Merging #229 into master will increase coverage by 0.08%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #229      +/-   ##
==========================================
+ Coverage   82.43%   82.51%   +0.08%     
==========================================
  Files          18       18              
  Lines         871      875       +4     
==========================================
+ Hits          718      722       +4     
  Misses        153      153
Impacted Files Coverage Δ
R/import_methods.R 80.41% <100%> (+0.41%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 70d26ca...70fbe9d. Read the comment docs.

@leeper
Copy link
Contributor

leeper commented Oct 2, 2019

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants