Bug fix: check names of ALL files (#78)

pkg/parser/parser.go

@@ -135,11 +135,6 @@ func (p *Parser) walkDir(dirname string, done chan bool) <-chan string {
 				return nil
 			}
 
-			if err := util.IsTextFileFromFilename(path); err != nil {
-				log.Debug().Str("file", path).Str("reason", err.Error()).Msg("skipping")
-				return nil
-			}
-
 			paths <- path
 			return nil
 		})

pkg/parser/violations.go

@@ -9,6 +9,7 @@ import (
 	"time"
 
 	"github.com/get-woke/woke/pkg/result"
+	"github.com/get-woke/woke/pkg/util"
 
 	"github.com/rs/zerolog/log"
 )
@@ -43,6 +44,12 @@ func (p *Parser) generateFileViolations(file *os.File) (*result.FileResults, err
 		results.Results = append(results.Results, pathResult)
 	}
 
+	// Don't check file content if it's not a text file or file is empty
+	if err := util.IsTextFileFromFilename(filename); err != nil {
+		log.Debug().Str("file", filename).Str("reason", err.Error()).Msg("skipping content")
+		return results, nil
+	}
+
 	reader := bufio.NewReader(file)
 
 	line := 1

pkg/parser/violations_test.go

@@ -75,6 +75,17 @@ func TestGenerateFileViolations(t *testing.T) {
 		assert.Len(t, res.Results, 1)
 		assert.Regexp(t, "^Filename violation: ", res.Results[0].Reason())
 	})
+
+	t.Run("filename violation for empty file", func(t *testing.T) {
+		f, err := newFileWithPrefix(t, "empty-whitelist-", "")
+		assert.NoError(t, err)
+
+		p := testParser()
+		res, err := p.generateFileViolationsFromFilename(f.Name())
+		assert.NoError(t, err)
+		assert.Len(t, res.Results, 1)
+		assert.Regexp(t, "^Filename violation: ", res.Results[0].Reason())
+	})
 }
 
 // newFile creates a new file for testing. The file, and the directory that the file