Bug fix: check names of ALL files #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eedorenko
force-pushed
the
eedorenko/fix-empty-files
branch
from
25665f0
to
3d905d9
Compare
eedorenko
force-pushed
the
eedorenko/fix-empty-files
branch
from
3d905d9
to
dad0dd5
Compare
Codecov Report
@@ Coverage Diff @@
## main #78 +/- ##
=======================================
Coverage 95.52% 95.52%
=======================================
Files 21 21
Lines 469 469
=======================================
Hits 448 448
Misses 12 12
Partials 9 9
Continue to review full report at Codecov.
|
caitlinelfring
approved these changes
May 21, 2021
| @@ -75,6 +75,17 @@ func TestGenerateFileViolations(t *testing.T) { | |||
| assert.Len(t, res.Results, 1) | |||
| assert.Regexp(t, "^Filename violation: ", res.Results[0].Reason()) | |||
| }) | |||
|
|
|||
| t.Run("filename violation for empty file", func(t *testing.T) { | |||
caitlinelfring
changed the title
Closed
caitlinelfring
added a commit
that referenced
this pull request
Jun 20, 2021
This reverts commit 7cb1c2d.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Check file names of all files in the target path.
What is the current behavior? (You can also link to an open issue here)
Currently names of empty files and just non-text files are not analyzed.
What is the new behavior (if this is a feature change)?
Analyze names of all files in the target path, but still skip analyzing content of empty files and non-text files.
Does this PR introduce a breaking change? (What changes might users need to make due to this PR?)
The linter may detect more violations as all file names are analyzed. If, for some reason, names of some files should not be analyzed, they should be added to the ignore list.
Other information: