Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/sonarqube index #162

Merged
merged 3 commits into from
Nov 18, 2021

Conversation

cognitivegears
Copy link
Contributor

Please check if the PR fulfills these requirements

  • [ X ] The commit message follows our guidelines
  • [ X ] Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features) see docs/README.md

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

Fix for Issue #161

What is the current behavior? (You can also link to an open issue here)

Currently the startColumn is set to 1 incorrectly for file/path level findings. For Sonarqube to read these findings correctly, the startColumn must be set to 0

What is the new behavior (if this is a feature change)?

Changed the startColumn to 1 in the case where both startColumn and endColumn are 1.

Does this PR introduce a breaking change? (What changes might users need to make due to this PR?)
No

Other information:

@codecov
Copy link

codecov bot commented Nov 17, 2021

Codecov Report

Merging #162 (2d48d54) into main (e1176dc) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #162      +/-   ##
==========================================
+ Coverage   95.84%   95.85%   +0.01%     
==========================================
  Files          22       22              
  Lines         746      748       +2     
==========================================
+ Hits          715      717       +2     
  Misses         19       19              
  Partials       12       12              
Impacted Files Coverage Δ
pkg/printer/sonarqube.go 92.85% <100.00%> (+0.35%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee781d3...2d48d54. Read the comment docs.

@caitlinelfring caitlinelfring merged commit 8fb42f5 into get-woke:main Nov 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants