feat: model lightning payment fees #1213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Restioson
force-pushed
the
model-lightning-fees
branch
from
10243c5
to
c2f8a87
Compare
6 tasks
holzeis
approved these changes
Sep 7, 2023
I've got a branch for this (#1245) :) This is just modelling the data and making it available to the frontend |
In that case, should we disable displaying the fee if it's an inbound payment? |
It will always be 0 so we could as well hide it. |
I guess no, if it is an inbound payment we don't have to display the fee. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is how this looks for a payment from the faucet:
I'm just not really sure if this is true: is the fee for faucet -> wallet really 0?
This brings us closer to fully implementing #872