Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display more fee information when opening a DLC channel #2062

Merged
merged 7 commits into from
Mar 1, 2024
Merged

Display more fee information when opening a DLC channel #2062

merged 7 commits into from
Mar 1, 2024

Commits on Mar 1, 2024

  1. chore(ln-dlc-node): Rewrite funding transaction test 

    Soon `rust-dlc` will enforce including at least one change output per
party in the funding transaction, so that either party can fee-bump
it.

The original `can_open_channel_with_min_inputs` test actually forced
`rust-dlc` to generate a change-output-less funding transaction. This
is valid for now, but it doesn't help to build on assumptions
that are going to change soon.

The new test simply checks that the funding transaction pays fees at the
expected fee rate. If we can trust `rust-dlc` to respect the fee rate
we give it, we can confidently display this information to a user who
is about to open a channel, so that they know the transaction fee cost
of their action.
    @luckysori
    luckysori committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    51357c6 View commit details
    Browse the repository at this point in the history

  2. chore(ln-dlc-node): Reproduce bug when calculating DLC channel fees

    @luckysori
    luckysori committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    d0349ef View commit details
    Browse the repository at this point in the history

  3. fix(ln-dlc-node): Calculate DLC channel fee reserve correctly

    @luckysori
    luckysori committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    10047c7 View commit details
    Browse the repository at this point in the history

  4. chore: Extract function to estimate DLC channel fee reserve

    @luckysori
    luckysori committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    a9d20ff View commit details
    Browse the repository at this point in the history

  5. feat(app): Display fee reserve and funding TX fee estimate 

    The funding tx fee is just an estimate and it is usually slightly
overestimated.

We've had to further increase the size of the bottom sheets to fit all
the information on screen.
    @luckysori
    luckysori committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    b42ff54 View commit details
    Browse the repository at this point in the history

  6. fix(app): Remove fee from total on confirmation bottom sheet 

    On the confirmation bottom sheet, we tell the user that some coins
will be locked up in the DLC channel. This message seems to imply that
these coins will still be owned by the user.

The margin and the collateral reserve make sense, but any fee paid or
reserved should probably be excluded. We could summarise this
information elswhere on the screen, but I don't think it is necessary
as all the information is already present separately.
    @luckysori
    luckysori committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    35a5333 View commit details
    Browse the repository at this point in the history

  7. fix(app): Rename reservedFeeSats to fundingTxFee 

    The value that we were displaying corresponded to half of the funding
transaction fee.

The fee reserve cannot be derived just by looking at the funding
transaction, as it is included in the funding transaction shared
output. Eventually, we should display the fee reserve in the
corresponding wallet history entry (and perhaps in a channel details
section too).
    @luckysori
    luckysori committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    0d8c36c View commit details
    Browse the repository at this point in the history