Update `bdk` to version `1.0.0-alpha.6` #2094

luckysori · 2024-02-26T07:25:49Z

Fixes #788.
Fixes #2016.
Fixes #2014.
Fixes #1990.
Fixes #1960 (reopen if not true after testing on public regtest).

I removed as much code as possible, although I gave up on making drastic changes to Flutter.
I haven't tested the app extensively. Just sending and receiving payments.
It would be great to merge this ASAP to avoid having to do any rebasing. Smaller PRs will have an easier time rebasing onto these changes.

coordinator/Cargo.toml

holzeis · 2024-02-26T11:19:34Z

@luckysori will this also fix #1960 and https://github.com/get10101/meta/issues/351 ?

luckysori · 2024-02-26T11:27:12Z

@luckysori will this also fix #1960 and get10101/meta#351 ?

Good point. I will try your repro and report back.

luckysori · 2024-02-26T13:08:15Z

@luckysori will this also fix #1960 and get10101/meta#351 ?

Good point. I will try your repro and report back.

@holzeis: really hard to say locally, because the sync is so fast. I didn't run into it though.

holzeis

Looks good so far. Didn't manage to look at all changes yet, but will continue tomorrow.

coordinator/src/admin.rs

coordinator/src/bin/coordinator.rs

coordinator/src/db/liquidity_options.rs

coordinator/src/dlc_handler.rs

coordinator/src/lib.rs

coordinator/src/node.rs

crates/ln-dlc-node/src/blockchain.rs

luckysori · 2024-02-28T06:16:17Z

@holzeis: I've addressed your early comments here.

holzeis

very nice 👍

A lot of feel good changes in there :)

crates/ln-dlc-node/src/dlc_wallet.rs

holzeis · 2024-02-28T10:36:07Z

crates/ln-dlc-node/src/dlc_wallet.rs

+
+        // This is a standard base weight (without inputs or change outputs) for on-chain DLCs. We
+        // assume that this value is still correct for DLC channels.
+        let funding_tx_base_weight = 212;


🔧 That would probably be better placed as constant.

True, although I didn't change this code with this PR.

In any case, I think it disappears with #2062, so we can wait for that one to merge.

holzeis · 2024-02-28T10:37:07Z

crates/ln-dlc-node/src/dlc_wallet.rs

+        };
+
+        coin_selector
+            .run_bnb(metric, 100_000)


❓ What is the 100_000 defining?

From the docs:

/// The method keeps trying until no better solution can be found, or we reach `max_rounds`.

I just took this value (a long time ago 😛) from the bdk_coin_select docs/examples. I can add a constant for it in a separate commit.

holzeis · 2024-02-28T10:38:13Z

crates/ln-dlc-node/src/dlc_wallet.rs

+            .run_bnb(metric, 100_000)
+            .map_err(|e| dlc_manager::error::Error::WalletError((format!("{e:#}")).into()))?;
+
+        debug_assert!(coin_selector.is_target_met(target));


🤔 Is it safe to continue here in prod? since we only debug_assert, or should we also gracefully print an error and return?

Old code. I just copied this from the bdk_coin_select docs/examples. It's safe because a coin selection that didn't meet its target will just fail later.

But I agree that we should fail early. I can add this to #2062.

holzeis · 2024-02-28T10:42:24Z

crates/ln-dlc-node/src/ln/event_handler.rs

 use std::sync::Arc;
 use tokio::sync::watch;

-pub type PendingInterceptedHtlcs = Arc<Mutex<HashMap<PublicKey, InterceptionDetails>>>;
 pub type EventSender = watch::Sender<Option<Event>>;


❓ is this still used?

I would love to remove it. I remember keeping it on purpose because I wasn't sure. I can try to get rid of it now.

AFAICT, after this PR it's only used by the app to generate an EventType::SpendableOutputs.

The app uses that as one of the triggers to create a new backup. This is obviously completely irrelevant for most of the apps in production, so I wouldn't mind removing it.

What do you think?

I will open a separate PR to remove it.

mobile/lib/features/wallet/send/confirm_payment_modal.dart

mobile/native/src/api.rs

mobile/native/src/destination.rs

mobile/native/src/ln_dlc/mod.rs

mobile/native/src/orderbook.rs

I'm interested in including a patch[^1] which will forward errors from the Esplora backend. This will make debugging easier. [^1]: bitcoindevkit/rust-esplora-client@269360f.

With the previous patch we can now use the `just maker` recipe knowing that it will work for Linux too.

luckysori requested review from bonomat and holzeis February 26, 2024 07:25

luckysori self-assigned this Feb 26, 2024

luckysori commented Feb 26, 2024

View reviewed changes

coordinator/Cargo.toml Outdated Show resolved Hide resolved

luckysori force-pushed the feat/two-bdks branch 4 times, most recently from 60963b0 to b3f0b1f Compare February 26, 2024 10:13

This was referenced Feb 26, 2024

Remove RGS #2070

Closed

Display more fee information when opening a DLC channel #2062

Merged

luckysori force-pushed the feat/two-bdks branch from b3f0b1f to d20d0fb Compare February 26, 2024 10:37

luckysori force-pushed the feat/two-bdks branch 2 times, most recently from 64b1529 to 32202c9 Compare February 26, 2024 12:45

luckysori force-pushed the feat/two-bdks branch 2 times, most recently from 7d85daf to 26ef02c Compare February 26, 2024 13:36

luckysori mentioned this pull request Feb 27, 2024

fix: Handle wallet sync error during startup #2090

Merged

luckysori force-pushed the feat/two-bdks branch 4 times, most recently from dec3efd to b37cb30 Compare February 27, 2024 13:09

holzeis reviewed Feb 27, 2024

View reviewed changes

luckysori force-pushed the feat/two-bdks branch from b37cb30 to ba0c3ae Compare February 28, 2024 06:14

holzeis approved these changes Feb 28, 2024

View reviewed changes

holzeis linked an issue Feb 28, 2024 that may be closed by this pull request

Update to a more recent version of rust-bitcoin #1923

Closed

luckysori added 2 commits March 1, 2024 15:59

feat: Update bdk to version 1.0.0-alpha.6

175239a

chore: Update esplora-client dependency

ab58d35

I'm interested in including a patch[^1] which will forward errors from the Esplora backend. This will make debugging easier. [^1]: bitcoindevkit/rust-esplora-client@269360f.

luckysori added 3 commits March 1, 2024 15:59

fix(justfile): Allow just maker to be run on Linux too

a06d6d3

chore(ci): Use just maker recipe in ci.yml

c59d24f

With the previous patch we can now use the `just maker` recipe knowing that it will work for Linux too.

chore(ln-dlc-node): Add COIN_SELECTION_MAX_ROUNDS constant

286271c

luckysori mentioned this pull request Mar 1, 2024

Reduce the number of storage traits #2128

Open

luckysori force-pushed the feat/two-bdks branch from ba0c3ae to 286271c Compare March 1, 2024 05:05

luckysori enabled auto-merge March 1, 2024 05:06

luckysori added this pull request to the merge queue Mar 1, 2024

Merged via the queue into main with commit 5ce7ec8 Mar 1, 2024
20 checks passed

luckysori deleted the feat/two-bdks branch March 1, 2024 05:30

This was referenced Mar 1, 2024

On chain balance and history is gone #2129

Closed

Help user to perfom a full sync after the bdk upgrade #2130

Closed

Restioson mentioned this pull request Mar 6, 2024

10101 in WASM #2166

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update `bdk` to version `1.0.0-alpha.6` #2094

Update `bdk` to version `1.0.0-alpha.6` #2094

luckysori commented Feb 26, 2024 •

edited

holzeis commented Feb 26, 2024 •

edited

luckysori commented Feb 26, 2024

luckysori commented Feb 26, 2024

holzeis left a comment

luckysori commented Feb 28, 2024

holzeis left a comment

holzeis Feb 28, 2024

luckysori Mar 1, 2024

holzeis Feb 28, 2024

luckysori Mar 1, 2024 •

edited

holzeis Feb 28, 2024

luckysori Mar 1, 2024

holzeis Feb 28, 2024

luckysori Mar 1, 2024

luckysori Mar 1, 2024

luckysori Mar 1, 2024

Update bdk to version 1.0.0-alpha.6 #2094

Update bdk to version 1.0.0-alpha.6 #2094

Conversation

luckysori commented Feb 26, 2024 • edited

holzeis commented Feb 26, 2024 • edited

luckysori commented Feb 26, 2024

luckysori commented Feb 26, 2024

holzeis left a comment

Choose a reason for hiding this comment

luckysori commented Feb 28, 2024

holzeis left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

luckysori Mar 1, 2024 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Update `bdk` to version `1.0.0-alpha.6` #2094

Update `bdk` to version `1.0.0-alpha.6` #2094

luckysori commented Feb 26, 2024 •

edited

holzeis commented Feb 26, 2024 •

edited

luckysori Mar 1, 2024 •

edited