Feat: Add closing tx #2099
Merged
Feat: Add closing tx #2099
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
holzeis
force-pushed
the
feat/add-closing-tx
branch
from
92e2e86
to
f36fb07
Compare
holzeis
changed the base branch from
main
to
chore/record-contract-transactions
holzeis
force-pushed
the
chore/record-contract-transactions
branch
from
37c7d83
to
3c58a99
Compare
holzeis
force-pushed
the
feat/add-closing-tx
branch
from
f36fb07
to
07fecc3
Compare
holzeis
force-pushed
the
feat/add-closing-tx
branch
from
07fecc3
to
e94d1c5
Compare
bonomat
approved these changes
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the closing txid to the dlc channels api and the channels screen in the settings (see screenshot below).
depends on get10101/rust-dlc#13
Note this is a breaking change. Old closed channels can't be read anymore. But given that old closed channel state don't provide any valuable information, I think this is acceptable.