Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(emergency kit): Add option to rollback channel to last stable state #2146

Merged
merged 3 commits into from Mar 4, 2024

Conversation

holzeis
Copy link
Contributor

@holzeis holzeis commented Mar 4, 2024

This might become very handy in case the protocol got stuck in an intermediate state. Unfortunately this will not help if one side has already reached the final state, while the other hasn't.

e.g. helps to recover from that #2137

@holzeis holzeis self-assigned this Mar 4, 2024
Copy link
Contributor

@luckysori luckysori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's okay to add this simple emergency button during the beta phase.

After the beta phase, I would not be comfortable letting the user delete their latest channel data, because they would have to trust the coordinator to do the same to do so safely.

@holzeis holzeis force-pushed the chore/add-emergency-kit-to-rollback-channel-state branch from 40ca117 to ed4a072 Compare March 4, 2024 14:47
@holzeis holzeis changed the base branch from main to chore/recover-from-settle-confirmed March 4, 2024 14:49
@holzeis holzeis force-pushed the chore/recover-from-settle-confirmed branch from 9783f94 to 99217c9 Compare March 4, 2024 14:50
@holzeis holzeis force-pushed the chore/add-emergency-kit-to-rollback-channel-state branch from ed4a072 to e3a68bc Compare March 4, 2024 14:50
Base automatically changed from chore/recover-from-settle-confirmed to main March 4, 2024 15:05
@holzeis holzeis added this pull request to the merge queue Mar 4, 2024
Merged via the queue into main with commit 976706a Mar 4, 2024
20 checks passed
@holzeis holzeis deleted the chore/add-emergency-kit-to-rollback-channel-state branch March 4, 2024 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants