feat(web): show transaction details in a dialog #2177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we relied on the regular wallet refresh to refresh the frontend. With this fix, we sync the wallet and refresh right afterwards. Signed-off-by: Philipp Hoenisch <philipp@coblox.tech>
putting the wallet history next to send/receive gives a better overview as the history is always shown. Signed-off-by: Philipp Hoenisch <philipp@coblox.tech>
Withdraw reminds me of _withdrawing_ from an exchange while this is its own wallet from which you can _send_. Signed-off-by: Philipp Hoenisch <philipp@coblox.tech>
Signed-off-by: Philipp Hoenisch <philipp@coblox.tech>
this will influence date and number formatting (unless overwritten). Signed-off-by: Philipp Hoenisch <philipp@coblox.tech>
If the tx is older than 30 minutes, it will show the date, otherwise it will show something like 'moments ago', '15 minutes ago' Signed-off-by: Philipp Hoenisch <philipp@coblox.tech>
|
Looks good, will look at the code later. nit: The history could use a header 🙂 |
I decided against it to not have to align the sizes with the tabs on the left 🙈 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #1927
Screen.Recording.2024-03-07.at.3.18.38.pm.mov