Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not error when user is typing send amount #2194

Merged
merged 3 commits into from
Mar 8, 2024
Merged

Do not error when user is typing send amount #2194

merged 3 commits into from
Mar 8, 2024

Commits on Mar 8, 2024

  1. refactor(ln-dlc-node): Move estimate_fee method to wallet module

    @luckysori
    luckysori committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    e67d91a View commit details
    Browse the repository at this point in the history

  2. chore: Do not check address network when estimating fee 

    It's completely unnecessary because a fee estimate is purely
informational.
    @luckysori
    luckysori committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    9a10d5d View commit details
    Browse the repository at this point in the history

  3. fix(app): Don't error when user is typing send amount 

    When the user is about to send on-chain and is typing the send amount,
we dynamically calculate a fee estimate so that we can update the
screen as they update the value.

This is nice, but the user will inevitably start by typing in small
amounts for which calculating a fee does not make economical sense.

We enhance the library code to handle this case explicitly by using a
error enum variant `EstimateFeeError::SendAmountBelowDust`. We can
then leverage this in the app backend to simply ignore this kind of
error.
    @luckysori
    luckysori committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    46fea4d View commit details
    Browse the repository at this point in the history