Do not error when user is typing send amount #2194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's completely unnecessary because a fee estimate is purely informational.
When the user is about to send on-chain and is typing the send amount, we dynamically calculate a fee estimate so that we can update the screen as they update the value. This is nice, but the user will inevitably start by typing in small amounts for which calculating a fee does not make economical sense. We enhance the library code to handle this case explicitly by using a error enum variant `EstimateFeeError::SendAmountBelowDust`. We can then leverage this in the app backend to simply ignore this kind of error.
holzeis
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2190.
When the user is about to send on-chain and is typing the send amount, we dynamically calculate a fee estimate so that we can update the screen as they update the value.
This is nice, but the user will inevitably start by typing in small amounts for which calculating a fee does not make economical sense.
We enhance the library code to handle this case explicitly by using a error enum variant
EstimateFeeError::SendAmountBelowDust. We can then leverage this in the app backend to simply ignore this kind of error.