chore: Improve notification messages #2374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
"open your app to execute the expiration" 🔫 |
SXBT69
approved these changes
Apr 8, 2024
holzeis
force-pushed
the
chore/improve-notifications
branch
2 times, most recently
from
2f9fb77
to
d60f9c7
Compare
|
a862e02 adds the side that got liquidated to the order reason. Based on that we can notify the user about who got liquidated. See below the three new notifications that are affected by that.
|
holzeis
force-pushed
the
chore/improve-notifications
branch
from
d60f9c7
to
a862e02
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subject for discussion, but I think the adapted messages might be clearer and more fun. :)
follow up to review remarks on #2354