fix: Derive referral code from node id for referral widget #2444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is not ideal, but since the referral code can be derived deterministically from the node id its safe to do and will ensure that the app will not fail to start. This fixes an issue where the referral status is not yet set because the app hasn't processed the authenticated message from the coordinator yet.
bonomat
reviewed
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not ideal, but since the referral code can be derived deterministically from the node id its safe to do and will ensure that the app will not fail to start.
This fixes an issue where the referral status is not yet set because the app hasn't processed the authenticated message from the coordinator yet. (happened because the referral widget will be shown immediately on the wallet screen after init, which can lead to that race condition)
fixes #2442