Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reconnect to orderbook WebSocket if app stream ends #268

Merged
merged 4 commits into from Mar 16, 2023
Merged

Reconnect to orderbook WebSocket if app stream ends #268

merged 4 commits into from Mar 16, 2023

Conversation

luckysori
Copy link
Contributor

Fixes #263.

@luckysori
chore(orderbook-client): Add reconnect logic to example
31eec99
@luckysori
feat(native): Reconnect to orderbook WS if stream ends
ce80607
@luckysori
chore(native): Spawn orderbook subscription directly
39c1873 
If we block on the completion of a future and then spawn another
future straight away, the first future completes instantly doin no
interesting work. We can just spawn the second future directly.
@luckysori
refactor(native): Refactor orderbook client
3afd8be
@luckysori luckysori self-assigned this Mar 16, 2023
bonomat
bonomat approved these changes Mar 16, 2023
View reviewed changes
Copy link
Contributor

@bonomat bonomat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice. Thanks

@luckysori
Copy link
Contributor Author

bors r+

@bors
Copy link
Contributor

bors bot commented Mar 16, 2023

Build succeeded:

@bors bors bot merged commit 64bf3b0 into main Mar 16, 2023
5 checks passed
@bors bors bot deleted the feat/orderbook-client-reconnect branch March 16, 2023 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bonomat bonomat bonomat approved these changes

@da-kami da-kami Awaiting requested review from da-kami

Assignees

@luckysori luckysori

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Orderbook client cannot reconnect to orderbook WS
2 participants
@luckysori @bonomat