Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect copy in mobile pay component #183 is Fixed #184

Merged
merged 2 commits into from
Jan 6, 2024

Conversation

harith-hacky03
Copy link

Fixed the this.invoice in payment page

@bumi bumi requested a review from rolznz January 5, 2024 12:43
@@ -142,7 +142,7 @@ export class SendPayment extends withTwind()(BitcoinConnectElement) {
block
@click=${this._copyAndDisplayInvoice}
>
${qrIcon}Copy & Display this.invoice
${qrIcon}Copy & Display
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
${qrIcon}Copy & Display
${qrIcon}Copy & Display invoice

@rolznz
Copy link
Collaborator

rolznz commented Jan 5, 2024

Thanks @harith-hacky03 ! please see my suggestion.

@harith-hacky03
Copy link
Author

Yeah Completed your suggestion too. Thank you @rolznz

@harith-hacky03
Copy link
Author

Hope it helps and you will merge it . Thank you

@rolznz rolznz merged commit 1eeca52 into getAlby:master Jan 6, 2024
2 checks passed
@rolznz
Copy link
Collaborator

rolznz commented Jan 6, 2024

Thanks @harith-hacky03 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants