Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send screen from popup should not show "Remember and set a budget" when i.e. pasting a lightning invoice (or other screens) #1510

Closed
bitcoinuser opened this issue Sep 23, 2022 · 5 comments · Fixed by #1541
Assignees
Labels
enhancement New feature or request frontend All things frontend development related good first issue Good for newcomers
Milestone

Comments

@bitcoinuser
Copy link
Contributor

bitcoinuser commented Sep 23, 2022

Describe the bug

If I create a ln invoice on a wallet like Phoenix and copy it and paste on Alby, Alby show the option Remember and set a budget. But doesn't make sense, because it's not a service or a page, so it's not saved.

Screenshots

Captura de tela de 2022-09-23 10-59-01

To Reproduce

Steps to reproduce the behavior:

  1. Generate a ln invoice on a ln wallet like Phoenix and copy the invoice.
  2. Click on Alby send button, then paste the invoice and click continue button

Expected behavior

Remember and set a budget option not be showed.

Alby information

  • Alby Version: 1.15.1
@escapedcat escapedcat added enhancement New feature or request good first issue Good for newcomers frontend All things frontend development related labels Sep 25, 2022
@escapedcat escapedcat changed the title Remember and set a budget should be hidden when pasting a lightning invoice Send screen from popup should not show "Remember and set a budget" when i.e. pasting a lightning invoice (or other screens) Sep 25, 2022
@vaibhavgarg237
Copy link
Contributor

I'm working on this

@escapedcat
Copy link
Contributor

I'm working on this

Thanks! Let me know if you get stuck or need more info

@escapedcat escapedcat added this to the v1.17 milestone Sep 26, 2022
@escapedcat
Copy link
Contributor

Heyhey @vaibhavgarg237 , did you already start with this? Do you need any support?

@vaibhavgarg237
Copy link
Contributor

Heyhey @vaibhavgarg237 , did you already start with this? Do you need any support?

It's almost complete, I got occupied in some office work...
Although I was facing some issues related to running tests locally. So I was thinking to first run locally and then do the PR. Will create the draft PR today...

@escapedcat
Copy link
Contributor

Will create the draft PR today

Perfect, yes! No worries if it's not "ready ready" yet. Just seeing some progress is already helpful.
Thanks for your quick reply!

vaibhavgarg237 added a commit to vaibhavgarg237/lightning-browser-extension that referenced this issue Sep 28, 2022
vaibhavgarg237 added a commit to vaibhavgarg237/lightning-browser-extension that referenced this issue Sep 29, 2022
@escapedcat escapedcat modified the milestones: v1.17, v1.18 Oct 3, 2022
bumi added a commit that referenced this issue Oct 16, 2022
fix: remove Remember & set budget from send #1510
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request frontend All things frontend development related good first issue Good for newcomers
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants