Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add discovery page vida project #2417

Merged
merged 5 commits into from
May 16, 2023

Conversation

lujakob
Copy link
Contributor

@lujakob lujakob commented May 10, 2023

Describe the changes you have made in this PR

Add vida project to discovery page

Link this PR to an issue [optional]

Fixes #2416

Type of change

(Remove other not matching type)

  • feat: New feature (non-breaking change which adds functionality)

Checklist

  • My code follows the style guidelines of this project and performed a self-review of my own code
  • New and existing tests pass locally with my changes
  • I checked if I need to make corresponding changes to the documentation (and made those changes if needed)

@github-actions
Copy link

github-actions bot commented May 10, 2023

🚀 Thanks for the pull request!

Here are the current build files for testing:

Download and unzip the file for your browser. Refer to the readme for detailed install instructions.


This build is brought to you by: channel.ninja (who recently dropped 1000 sats):


Want to sponsor the next build? send some sats to ⚡️builds@getalby.com (don't forget to provide your name)

Don't forget: keep earning sats!

@im-adithya
Copy link
Member

You can reuse the one we use for vida.page

@lujakob
Copy link
Contributor Author

lujakob commented May 11, 2023

@bitcoinuser why should this be in the Nostr section?

@bitcoinuser
Copy link
Contributor

@bitcoinuser why should this be in the Nostr section?

I mean lighthing.

@lujakob
Copy link
Contributor Author

lujakob commented May 11, 2023

@bitcoinuser why should this be in the Nostr section?

I mean lighthing.

There is no lightning section. I would propose to add it to the "Miscellanous" section. As there already is a "Vida" item, I propose to name the new one "Vida.live". What do you think?

@bitcoinuser
Copy link
Contributor

@bitcoinuser why should this be in the Nostr section?

I mean lighthing.

There is no lightning section. I would propose to add it to the "Miscellanous" section. As there already is a "Vida" item, I propose to name the new one "Vida.live". What do you think?

Agree

@lujakob
Copy link
Contributor Author

lujakob commented May 11, 2023

Bildschirmfoto 2023-05-11 um 10 58 14

@lujakob
Copy link
Contributor Author

lujakob commented May 16, 2023

@reneaaron this is ready for review. Thx

Copy link
Contributor

@reneaaron reneaaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK

@reneaaron reneaaron merged commit 9666160 into getAlby:master May 16, 2023
5 of 6 checks passed
@reneaaron
Copy link
Contributor

Thanks very much @lujakob!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Add https://vida.live/
4 participants